Feature: frontend borrower monthly income 34 & build errors #42
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@gchyuli GM! PR ready for review, let me know if there's anything I should change. |
evgongora
changed the title
evgongora
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request for TrustBridge - Close Issue
❗ Pull Request Information
This PR implements the monthly income field in the Account Settings module for borrower users. The field is conditionally rendered based on the user's role and includes proper validation, formatting, and translations.
Add here some information
🌀 Summary of Changes
Implemented a new form field specifically for borrowers
Added case-insensitive role checking to ensure proper display
Integrated with existing form validation and state management
Updated accountFormSchema with monthly income validation
Added validation for positive numbers
Made the field optional with proper type handling
Added new translation keys for monthly income field
Included label, placeholder, and description texts
Maintained multilingual support
Used shadcn/ui components for consistent styling
Added proper number input handling
Implemented form validation messages
🛠 Testing
Evidence
📂 Related Issue
This pull request will close #34 upon merging.
🎉 Thank you for reviewing this PR! 🎉