-
-
Notifications
You must be signed in to change notification settings - Fork 831
[Improvements🛠️]:Update tools directory, CI workflow, and dependencies for better compatibility and performance #1790
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
VerUP: version up node-gyp, mocha, tar, prebuild, node-addon-api
Hey there, I am curious, what kind of tests have run to verify the version bump is not creating other issues, regressions, etc. ? |
Hello, @YasharF. I have run the workflow in this PR and passed all environments with the changes in semver-check.js and BinaryBuilder.Dockerfile. Since I'm running the workflow on a fork repository, I'm not sure what the results will be on master repository Actions. The issue was that the version checked in After making these changes, I ran the workflow with the updated versions from the Renovate PR, and all environments passed successfully. Thank you. |
I ran the same test suite with this branch as I did in #1788, and everything worked as expected to me. I get it if there are hesitations to merge these PRs, but it'd be nice to have a clarity on intent here, so that people like me can decide if we should wait for these PRs to be merged, or if we create a "temporary" fork to publish on NPM under a scope. @daniellockyer can you please shed some light on the maintenance status of this project 🙏🏽 |
Hello, there! It’s been a few months—just checking in to see how things are going. |
Just FYI folks, starting node 22.5, there is native sqlite support without having to worry about any external dependencies. Thanks a lot to the project maintainers for providing us with this very useful package for many years. I'm grateful. |
Thank you very much for providing the information! |
Changed tools/semver-check.js
Node.js 10 was end-of-life on December 31, 2021.
so using
process.versions.node
to always use the current Node.js version.This change solves fix GitHub Actions test failures caused by specifying Node.js '10.12.0'. node-sqlite3 testing with Node.js 18, so '10.12.0' isn’t need.
Changed tools/BinaryBuilder.Dockerfile
Added
--maxsockets=1
tonpm install
as a temporary workaround.This fixes the error:
Client network socket disconnected before secure TLS connection was established
in bullseye CI test.Changed workflow CI
arm64
architecture formacos-latest
.setup-msbuild
from v1 to v2 for better Windows11 compatibility.setuptools
installation step becausenode-gyp
v10 supports Python 3.12 by default.upload-artifact
due to test failures with the latest version.Upgrade some dependencies
node-addon-api
to 8.0.0 or higher. (Update dependency node-addon-api to v8 #1767 )tar
to 7.0.0 or higher. (Update dependency tar to v7 #1777 )node-gyp
to 10 or higher. (Update dependency node-gyp to v10 - autoclosed #1724 )These updates improve compatibility, performance, and security of your project.