-
Notifications
You must be signed in to change notification settings - Fork 44
Add ComponentArrays extension #407
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not familiar with ComponentArrays
. Can @mhauru, @penelopeysm, or @sunxd3 take a look, please?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Excellent work, @ErikQQY!
I only checked the main code (/src/
) but didn't look at the tests carefully.
@ErikQQY, can you update the PR summary to explain what the issue was preventing the use of |
@penelopeysm, can you also review this please? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very happy apart from the single comment!
Excellent work @ErikQQY! |
Replace: #345
Fix: #344
So in #344, the reason why ComponentArray failed with
DenseEuclideanMetric
is that the dense matrix inDenseEuclideanMetric
doesn't have the same axes as the input, and when we do linear algebra operations on two arrays with different axes, the result is just an ordinary Julia array, for example:But it's basically user's obligation to ensure consistent input data structure, so this PR ensures the input from user are axes-matching.
Some notes:
ComponentArrays
.src/adaptation/massmatrix.jl
are not related to fixingComponentArrays
.