-
Notifications
You must be signed in to change notification settings - Fork 44
Revive GPU tests #430
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Revive GPU tests #430
Conversation
It occurs to me that while we no longer throw warning messages for numerical errors, we can safely use ReTest.jl for GPU tests as well? AdvancedHMC.jl/test/hamiltonian.jl Lines 34 to 36 in 7067a90
|
@sunxd3, can you review this PR and help set up buildkite for this repo? |
The changes looks sensible. I messaged Tim who manages JuliaGPU on slack and I'll update when he returns. In the meantime, I don't know AHMC code in close detail. I remember |
ReTest.jl is introduced in #287 with the intention of allowing a subset of testing and providing a better summary of test results, see https://github.com/TuringLang/AdvancedHMC.jl/blob/main/test/README.md |
Got it, thanks. I wonder if we can use |
I may not quite understand here, we can directly call |
You are right -- this current PR is not discussing the use of ReTest 👍 |
I'm merging this now since we need the Buildkite script to be on |
The GPU pipeline should be set up https://buildkite.com/julialang/advancedhmc-dot-jl |
Fix: #429
Instead of completely removing the current ReTest.jl test suite, this PR moves the GPU tests to another test environment so that we can only use Test.