Added Dark Theme

[jitendravjh]

Closes #91

[github-actions]

Preview the changes: https://turinglang.org/pr-previews/92
Please avoid using the search feature and navigation bar in PR previews!

[shravanngoswamii]

I think preview workflow is not working, let me see it first!

[shravanngoswamii]

Text colors in lists is still white, is it intended to be like that?

[jitendravjh]

Text colors in lists is still white, is it intended to be like that?

fixed it!

[shravanngoswamii]

I think text color in navbar will look much better if it's white!

[shravanngoswamii]

Everything looks good to me, maybe @yebai would like to see colours once —
Main Site: https://turinglang.org/pr-previews/92
Docs Site: https://turinglang.org/docs/pr-previews/509

[yebai]

Thanks @jitendravjh and @shravanngoswamii! Maybe @penelopeysm can have a final say here?

[penelopeysm]

Hi @jitendravjh, this is great work :) I like the colours a lot (despite being an always-light-mode girl)

There are some small inconsistencies in the CSS variables between the cosmo and solar themes. You can see these here:

• Cosmo: https://github.com/thomaspark/bootswatch/blob/v5/dist/cosmo/_variables.scss
• Solar: https://github.com/thomaspark/bootswatch/blob/v5/dist/solar/_variables.scss

For example, solar sets

$breadcrumb-padding-y:              .375rem !default;
$breadcrumb-padding-x:              .75rem !default;

This leads to some moving around when the colour scheme is changed (warning: flashing colours)

css.mov

There are a couple of ways to get around this. One is to specifically override SCSS variables like the breadcrumb-padding ones.

The other is to use cosmo as a base theme and override every single colour variable. Basically, copy all the colour variables over from the base solar SCSS file into theming/theme-dark.scss (and replace any of them that you want to tweak, such as $body-color).

I would lean towards the latter, because using cosmo as a base will guarantee that we have all the non-colour CSS variables exactly the same. Furthermore, this will continue to hold true even if the Bootstrap themes are updated, meaning that it reduces the future maintenance burden.

[shravanngoswamii]

@jitendravjh Any updates?

[shravanngoswamii]

The other is to use cosmo as a base theme and override every single colour variable. Basically, copy all the colour variables over from the base solar SCSS file into theming/theme-dark.scss (and replace any of them that you want to tweak, such as $body-color).

This looks much better approach to me, using this there will no to minimal chances in theme and color inconsistencies in future!

[jitendravjh]

Apologies for the delay. The requested changes have been implemented. Please review and let me know if any further adjustments are needed.
@penelopeysm @shravanngoswamii

Main Site: https://turinglang.org/pr-previews/92
Docs Site: https://turinglang.org/docs/pr-previews/509

[penelopeysm]

Looks good!

[shravanngoswamii]

Thank you, @jitendravjh!

[yebai]

Thanks, @jitendravjh and @shravanngoswamii, for the nice improvements!