Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added check for cyclic reference issue #3

Closed
wants to merge 1 commit into from
Closed

Added check for cyclic reference issue #3

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions src/swaggerbank.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -236,6 +236,13 @@ class API {
console.error('Your object schema is undefined. This most likely means you are referencing an object that doesn\'t have a definition');
process.exit(-1);
}

// Does object schema reference itself?
if (objectName === refName) {
console.error(`Your object ${objectName} has an internal \$ref to itself (${refName})`);
process.exit(-1);
}

// Construct our template recursively for the object that is defined at the $ref tag location
const objectTemplate = this.constructTemplateForRef(objectSchema, objectName);
refTemplate[property] = { 'type': 'object', 'format': objectTemplate };
Expand Down