Fix #967: Removed repeated global path republishes + Button to change global waypoints during run#987
Merged
raghumanimehta merged 11 commits intoJul 6, 2026
Conversation
raghumanimehta
requested changes
Jul 2, 2026
raghumanimehta
left a comment
Contributor
There was a problem hiding this comment.
my bad, the requirements were not clear ig... we want to use the global path from the test plans.
I think a good design could be editting the mock_global_path.csv with new values then clicking the button on gui to change the global path to the one from csv i.e. stop using the one from test plan.
any questions?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
node_mock_global_path.py#967Changes Made
global_path_callbackfromnode_mock_global_path.py, the node no longer republishes the global path on every GPS messagepublish_global_path, called beforerclpy.spinreload_tokenROS 2 parameter and_on_set_parameterscallback to support runtime reloading, settingreload_tokento any new value re-reads the CSV and republishes the global pathVerification