Skip to content

Fix #967: Removed repeated global path republishes + Button to change global waypoints during run#987

Merged
raghumanimehta merged 11 commits into
mainfrom
MilcToast/stop-mock-global-path-gps-republish-967
Jul 6, 2026
Merged

Fix #967: Removed repeated global path republishes + Button to change global waypoints during run#987
raghumanimehta merged 11 commits into
mainfrom
MilcToast/stop-mock-global-path-gps-republish-967

Conversation

@MilcToast

@MilcToast MilcToast commented Jul 1, 2026

Copy link
Copy Markdown
Contributor

Description

Changes Made

  • Removed the GPS subscription and global_path_callback from node_mock_global_path.py, the node no longer republishes the global path on every GPS message
  • Added a one-time publish at startup via publish_global_path, called before rclpy.spin
  • Added a CSV file (global_paths/mock_global_path.csv) as a path source, with previous working path kept as a fallback if the CSV fails to load
  • Added a reload_token ROS 2 parameter and _on_set_parameters callback to support runtime reloading, setting reload_token to any new value re-reads the CSV and republishes the global path
  • Added a "Mock Global Path" control panel to the visualizer with a "Reload CSV" button that triggers the reload via ros2 param set /mock_global_path reload_token <n_clicks>

Verification

  • Confirmed that node_mock_global_path no longer continuously republishes on GPS messages (only logs once)
  • Confirmed that the global path is published once at startup and received by subscribers
  • Confirmed that editing mock_global_path.csv and clicking "Reload CSV" in the visualizer triggers a republish with the updated waypoints
  • Confirmed that the visualizer displays a success/error message after clicking "Reload CSV"

@MilcToast MilcToast self-assigned this Jul 1, 2026
@MilcToast MilcToast added the path Pathfinding team label Jul 1, 2026
@MilcToast MilcToast marked this pull request as ready for review July 1, 2026 09:19
@MilcToast MilcToast requested a review from raghumanimehta as a code owner July 1, 2026 09:19

@raghumanimehta raghumanimehta left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

my bad, the requirements were not clear ig... we want to use the global path from the test plans.

I think a good design could be editting the mock_global_path.csv with new values then clicking the button on gui to change the global path to the one from csv i.e. stop using the one from test plan.

any questions?

@raghumanimehta raghumanimehta merged commit 44dcee0 into main Jul 6, 2026
6 checks passed
@raghumanimehta raghumanimehta deleted the MilcToast/stop-mock-global-path-gps-republish-967 branch July 6, 2026 19:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

path Pathfinding team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

PATH: Update node_mock_global_path.py

2 participants