(Fixes #987) Expand edges of base pair rectangles #1002
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was an issue where the left-most and right-most base-pair rectangles would not expand all the way to the edge. This has now been fixed.
Contributor
Author
|
This might require a fix for #1001 first? The grid dropdown is currently missing, so it might not work for all cases. |
Member
|
Can this be taken out of draft and merged? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was an issue where the left-most and right-most base-pair rectangles would not expand all the way to the edge. This has now been fixed.
Description
The left-most and right-most squares have been shifted and expanded into rectangles. This fixes issue #987 where there would be some whitespace where the squares don't expand all the way to the edge.
Related Issue
Fixes #987
To reproduce the issue, click on
View->Base Pairsthen turn onDisplay as Rectangles. On the previous commits, this would end up with extra white space being shown at the beginning and end of the base pairs.Motivation and Context
This is a bug fix for issue #987.
How Has This Been Tested?
This has been tested (and works) with each of the example DNA designs. (
File->Load Example).Each test has been done on a Windows 11 PC, 1080p monitor, and the Arc browser (Chromium based) as well as on Google Chrome.
Screenshots (if appropriate):
Left-Most Base Pair
Right-Most Base Pair