Set initial parameters #9
Conversation
There was a problem hiding this comment.
Thanks, the structure (mostly) makes sense to me! I added a few comments on things we may not need.
I'm starting to learn towards more descriptive variable names (than PX2Tilde etc.) but that can be done later. I'm curious what was inconsistent about the naming convention? Do you mean the Uppercase vs lowercase names?
I think we should aim to drop the testing flags from this file as well and implement the tests properly. I feel like there are many more flags in the code that we will want to either move here or get rid of. I'm happy to add them later, unless you can find very obvious ones.
Co-authored-by: Tuomas Koskela <[email protected]>
…ergrassi.jl into 2-set-initial-parameters
|
Yes... sometimes the names start with uppercase (e.g. |
Since we are starting from scratch, let's fix that. I would say we follow https://docs.julialang.org/en/v1/manual/variables/#Stylistic-Conventions, ie. variable names are lowercase with underscores when necessary for word separation. |
Co-authored-by: Tuomas Koskela <[email protected]>
Co-authored-by: Tuomas Koskela <[email protected]>
…ergrassi.jl into 2-set-initial-parameters
|
The parameter is the standard deviation of the productivity shock. the file is the file containing balance_sheet_parameters.
or productivity_parameters.
________________________________
From: Tuomas Koskela ***@***.***>
Sent: 06 February 2025 10:34
To: UCL/Supergrassi.jl ***@***.***>
Cc: Subscribed ***@***.***>
Subject: Re: [UCL/Supergrassi.jl] Set initial parameters (PR #9)
⚠ Caution: External sender
@tkoskela commented on this pull request.
________________________________
In config/settings.yml<#9 (comment)>:
+ RiskFreeRate: "interestRate.csv"
+ assets: "firmData.csv"
+ DefaultSigma: "modelResults.csv"
Sorry I thought I made a comment on this yesterday but I can't find it anymore. I'd just like the names of these to follow the standard style. I also don't like DefaultSigma. The file seems to contain many variables besides sigma so maybe model_results is a reasonable name although it's not very descriptive. We can check with Lars what this is.
⬇️ Suggested change
- RiskFreeRate: "interestRate.csv"
- assets: "firmData.csv"
- DefaultSigma: "modelResults.csv"
+ risk_free_rate: "interestRate.csv"
+ assets: "firmData.csv"
+ model_results: "modelResults.csv"
—
Reply to this email directly, view it on GitHub<#9 (review)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/ABL2Y6YFRRIUQLWK3G2WIFT2OM3DZAVCNFSM6AAAAABWL6KCKWVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDKOJYGI3TQMJWGU>.
You are receiving this because you are subscribed to this thread.Message ID: ***@***.***>
|
Co-authored-by: Tuomas Koskela <[email protected]>
Main changes
I have added
settings.ymlthat in principle should contain all the hard-coded values used in the simulation.Further questions / decisions to be made