-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Set initial parameters #9
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, the structure (mostly) makes sense to me! I added a few comments on things we may not need.
I'm starting to learn towards more descriptive variable names (than PX2Tilde etc.) but that can be done later. I'm curious what was inconsistent about the naming convention? Do you mean the Uppercase vs lowercase names?
I think we should aim to drop the testing flags from this file as well and implement the tests properly. I feel like there are many more flags in the code that we will want to either move here or get rid of. I'm happy to add them later, unless you can find very obvious ones.
settings.yml
Outdated
input_derived_dir: derived | ||
|
||
required: | ||
inputs: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should outputs also be here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good point. I will add them. I will also keep the .mat formats for now... Just in case...
Co-authored-by: Tuomas Koskela <[email protected]>
…ergrassi.jl into 2-set-initial-parameters
Yes... sometimes the names start with uppercase (e.g. |
Since we are starting from scratch, let's fix that. I would say we follow https://docs.julialang.org/en/v1/manual/variables/#Stylistic-Conventions, ie. variable names are lowercase with underscores when necessary for word separation. |
Co-authored-by: Tuomas Koskela <[email protected]>
Co-authored-by: Tuomas Koskela <[email protected]>
…ergrassi.jl into 2-set-initial-parameters
Main changes
I have added
settings.yml
that in principle should contain all the hard-coded values used in the simulation.Further questions / decisions to be made