Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UI Improvements to Workspace Chat #179

Merged
merged 2 commits into from
Feb 10, 2025

Conversation

jaczhi
Copy link
Contributor

@jaczhi jaczhi commented Feb 8, 2025

Closes #160
Closes #159
Related to #161 (but does not close it because I haven't figured out a way to remove channels yet)

Improvements:

  • automatically scrolls to bottom upon entering chat
  • enter key sends message (shift+enter for newline)
  • prevent sending of empty messages
  • messages text now readable instead of white
  • added sent time (hh:mm am/pm) in addition to date
  • profile pictures are now 1) deterministic across users/devices, 2) different for each sender, can differentiate people by their PFP
  • prettified top navigation bar and buttons
  • use memos instead of functions for improved rendering efficiency
  • new UI and logic to create a chat channel
  • chat channels are no longer hardcoded (other than '#general' to avoid user confusion)

New look:
image

image

@jaczhi jaczhi self-assigned this Feb 8, 2025
@jaczhi
Copy link
Contributor Author

jaczhi commented Feb 8, 2025

I updated this PR; I added custom chat channels functionality

@jaczhi jaczhi requested a review from pulsejet February 8, 2025 21:27
@markverick
Copy link
Collaborator

I tested your PR; Everything you described looks good to me.

@jaczhi jaczhi merged commit 1823964 into UCLA-IRL:main Feb 10, 2025
1 check failed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[chat] hotkey to send a chat message [chat] scroll position
2 participants