Skip to content

Commit

Permalink
add comment
Browse files Browse the repository at this point in the history
  • Loading branch information
CAWorks-ChrisA committed Oct 2, 2024
1 parent f790488 commit c24e5eb
Showing 1 changed file with 5 additions and 0 deletions.
5 changes: 5 additions & 0 deletions src/adaptors/yjs-ndn-adaptor.ts
Original file line number Diff line number Diff line change
Expand Up @@ -177,6 +177,11 @@ export class NdnSvsAdaptor {

// NOTE: The following code depend on snapshot naming convention to work.
// Verify this part if there's a change in naming convention.
// NOTE: From Github Discussion:
// Though, this "update the snapshot response strategy on receiving new snapshot from SVS" logic is somewhat optional in nature.
// It is ran, such that if a blind fetch request reaches an endpoint, endpoint returns a good response.
// Just like snapshot responses, we don't have to guarantee absolute latest when it is about blind fetching.
// hence we can just use a rough "total count" for determining if it needs an update.
if (snapshotSVcount > oldSVCount) {
const firstSegmentName = decodedSnapshotName.append('50=%00').toString();
// Race Condition Note: The callback to here is faster than
Expand Down

0 comments on commit c24e5eb

Please sign in to comment.