Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: APPS 2389 2396 2397 Add identifier_global, history, edition metadata fields #951

Conversation

jendiamond
Copy link
Member

@jendiamond jendiamond commented Dec 7, 2023

Connected to APPS-2389-2396-2397

Add identifier-global, history, & edition metadata fields

Screenshot 2023-12-07 at 3 12 25 PM
Screenshot 2023-12-07 at 3 17 52 PM
property identifier_global
dynamic field identifier_global_ssim
label Identifier
predicate http://id.loc.gov/ontologies/bibframe/Identifier
required no
multiple yes
type string (english tokenization)
import from Identifier
searchable yes
faceted no
search results hide
item view show
grouping Find this Item
oai_dpla dc.identifier
importer guide Identifier

property history
dynamic field history_tesim
label History
predicate http://id.loc.gov/ontologies/bibframe/historyOfWork
required no
multiple yes
type string
import from History
searchable yes
faceted no
search results hide
item view show
grouping Notes
oai_dpla dc:description
importer guide History

property edition
dynamic field edition_ssm
label Edition
predicate http://id.loc.gov/ontologies/bibframe/editionStatement
required no
multiple yes
type string
import from Edition
searchable no
faceted no
search results hide
item view show
grouping Item Overview
oai_dpla dcterms:alternative
importer guide Edition

@jendiamond jendiamond self-assigned this Dec 7, 2023
app/controllers/catalog_controller.rb Show resolved Hide resolved
app/controllers/catalog_controller.rb Outdated Show resolved Hide resolved
Copy link
Contributor

@sourcefilter sourcefilter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Identifier should be a :symbol / _ssim field. I commented on this in a couple locations but not necessarily everywhere it needs to be changed

app/controllers/catalog_controller.rb Outdated Show resolved Hide resolved
app/models/ucla_metadata.rb Outdated Show resolved Hide resolved
Copy link
Contributor

@sourcefilter sourcefilter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🍉

@sourcefilter sourcefilter merged commit 4d3a611 into main Dec 8, 2023
2 checks passed
@sourcefilter sourcefilter deleted the APPS-2389-2396-2397_add-identifier-global_history_edition-metadata-fields branch December 8, 2023 20:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants