chore: APPS-3162 Replace SectionStaffSubjectLibrarian component with new TableComponent #111
+44
−11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Percy ScreenshotsIn order to conserve our percy screenshot allowance, percy is not configured to run automatically. Please make sure the PR is ready and all other checks are passing, then start it manually: 1. Visit https://github.com/UCLALibrary/ftva-website-nuxt/actions/workflows/percy.yml 2. Click the 'Run workflow' button in the blue bar. 3. Select the correct branch for this PR and click 'Run workflow' again to confirm. |
|
🚀 Deployed on https://deploy-preview-111--test-ftva.netlify.app |
…an-w-tablecomponent
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Connected to APPS-3162
Page/Pages Created/updated: /collections/la-rebellion/filmmakers/[slug].vue from #APPS-3162
Notes:
Replaced the old StaffSubjectLibrarian specific component with the new table component
https://deploy-preview-111--test-ftva.netlify.app/collections/la-rebellion/filmmakers/test-person?preview=true
Sidenote: I noticed the column headers on the table were askew (even before refactor), so I will create a ticket to fix those at the component level. The test data in storybook didn't reveal this issue since the column data I used was too uniform!
Time Report:
This took me 2ish hours to build this.
Checklist:
[ ] I completed any required mobile breakpoint styling[ ] I completed any required hover state styling[ ] I included a working spec file[] UX has reviewed this PR