Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: APPS-3109 Articles List ES query composable #97

Merged
merged 2 commits into from
Jan 16, 2025

Conversation

tinuola
Copy link
Contributor

@tinuola tinuola commented Jan 15, 2025

Connected to APPS-3109

Page updated: /pages/blog/index.vue

https://deploy-preview-97--test-ftva.netlify.app/blog

Notes:

  • Created composable to fetch Articles list from ES
  • Tested composable output (See console)

Checklist:

  • I added github label for semantic versioning
  • I assigned this PR to someone to review
  • [ ] I double checked it looks like the designs
  • [ ] I completed any required mobile breakpoint styling
  • [ ] I completed any required hover state styling
  • [ ] I included a working spec file
  • [ ] I added notes above about how long it took to build this component
  • [ ] UX has reviewed this PR

@tinuola tinuola self-assigned this Jan 15, 2025
Copy link
Contributor

Percy Screenshots

In order to conserve our percy screenshot allowance, percy is not configured to run automatically. Please make sure the PR is ready and all other checks are passing, then start it manually: 1. Visit https://github.com/UCLALibrary/ftva-website-nuxt/actions/workflows/percy.yml 2. Click the 'Run workflow' button in the blue bar. 3. Select the correct branch for this PR and click 'Run workflow' again to confirm.

Copy link
Contributor

github-actions bot commented Jan 15, 2025

🚀 Deployed on https://deploy-preview-97--test-ftva.netlify.app

@github-actions github-actions bot temporarily deployed to pull_request-97 January 15, 2025 23:18 Inactive
pages/blog/index.vue Outdated Show resolved Hide resolved
Copy link
Contributor

@pghorpade pghorpade left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@tinuola tinuola merged commit 9a10327 into main Jan 16, 2025
8 checks passed
@tinuola tinuola deleted the APPS-3109_paginated-articles-composable branch January 16, 2025 19:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants