Grad classes async bug fix #2094
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Examined the changed code; I don't think this was working before because it was trying to cast a Future to a String, which are completely unrelated and incompatible types. Combined with the fact that we explicitly ignore most exceptions at runtime, this would explain why it was silently failing. On a separate note, this is a good case study for the code style guide project... |
7 tasks
7 tasks
|
Unlinked original issue from this PR, since it doesn't seem to fix the grad classes bug. |
morebytes
approved these changes
Nov 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Updating fetching grad classes to be more consistent with how we fetch undergrad classes. Specifically, dealing with an async bug fix.
Changelog