Skip to content

Conversation

@dimovpetar
Copy link
Member

@dimovpetar dimovpetar commented Oct 15, 2025

Adds a tool for creation of UI Integration cards

JIRA: CPOUI5FOUNDATION-1147

@dimovpetar dimovpetar marked this pull request as draft October 15, 2025 13:26
@dimovpetar dimovpetar force-pushed the feat_create_integration_card branch from f9ce2d4 to f053b55 Compare October 17, 2025 08:35
@coveralls
Copy link

coveralls commented Oct 17, 2025

Pull Request Test Coverage Report for Build 18776052519

Details

  • 54 of 55 (98.18%) changed or added relevant lines in 5 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.5%) to 81.327%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/tools/create_integration_card/create_integration_card.ts 32 33 96.97%
Totals Coverage Status
Change from base Build 18772900611: 0.5%
Covered Lines: 1000
Relevant Lines: 1144

💛 - Coveralls

@dimovpetar dimovpetar force-pushed the feat_create_integration_card branch 4 times, most recently from 3d2d0d0 to e8928e4 Compare October 17, 2025 09:04
@dimovpetar dimovpetar marked this pull request as ready for review October 17, 2025 12:07
@dimovpetar dimovpetar force-pushed the feat_create_integration_card branch from 3beacf0 to 90d31e4 Compare October 21, 2025 12:47
Copy link
Member

@alexandar-mitsev alexandar-mitsev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you add some instructions in the template, or in the guidelines?
This one is very helpful for me - it always makes it work correcrlty when it tries to preview the card:

  • If you have npm start in the project, use it to test and run the card preview.

@dimovpetar
Copy link
Member Author

dimovpetar commented Oct 22, 2025

can you add some instructions in the template, or in the guidelines? This one is very helpful for me - it always makes it work correcrlty when it tries to preview the card:

  • If you have npm start in the project, use it to test and run the card preview.

Good point. I adjusted the ## 4. Preview Instructions and it seem to work well for me. Please retest it.

@RandomByte RandomByte force-pushed the feat_create_integration_card branch from 51f880f to 3bc2038 Compare October 24, 2025 07:43
@RandomByte
Copy link
Member

Rebased onto main after #69 has been merged

Comment on lines +12 to +14
"keywords": [],
"author": "",
"license": "ISC"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"keywords": [],
"author": "",
"license": "ISC"

If you agree, I would propose removing these optional fields from the package.json

"version": "1.0.0",
"description": "A basic template card project",
"scripts": {
"start": "npx http-server ./ -c-1 -o test/index.html",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"start": "npx http-server ./ -c-1 -o test/index.html",
"start": "http-server ./ -c-1 -o test/index.html",

No need for npx inside npm scripts since the dependency is correctly maintained

@RandomByte RandomByte force-pushed the feat_create_integration_card branch from 82898d0 to 64982e5 Compare October 24, 2025 09:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants