-
Notifications
You must be signed in to change notification settings - Fork 3
feat: Add tool that creates Integration Card #84
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
f9ce2d4 to
f053b55
Compare
Pull Request Test Coverage Report for Build 18776052519Details
💛 - Coveralls |
3d2d0d0 to
e8928e4
Compare
3beacf0 to
90d31e4
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can you add some instructions in the template, or in the guidelines?
This one is very helpful for me - it always makes it work correcrlty when it tries to preview the card:
- If you have npm start in the project, use it to test and run the card preview.
Good point. I adjusted the |
51f880f to
3bc2038
Compare
|
Rebased onto main after #69 has been merged |
| "keywords": [], | ||
| "author": "", | ||
| "license": "ISC" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| "keywords": [], | |
| "author": "", | |
| "license": "ISC" |
If you agree, I would propose removing these optional fields from the package.json
| "version": "1.0.0", | ||
| "description": "A basic template card project", | ||
| "scripts": { | ||
| "start": "npx http-server ./ -c-1 -o test/index.html", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| "start": "npx http-server ./ -c-1 -o test/index.html", | |
| "start": "http-server ./ -c-1 -o test/index.html", |
No need for npx inside npm scripts since the dependency is correctly maintained
82898d0 to
64982e5
Compare
Adds a tool for creation of UI Integration cards
JIRA: CPOUI5FOUNDATION-1147