-
Notifications
You must be signed in to change notification settings - Fork 280
feat(framework): Custom Illustrations Documentation & API Enhancement #12260
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
kgogov
wants to merge
3
commits into
main
Choose a base branch
from
using-custom-illus-docs
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+893
−19
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
30635c4
to
03f68af
Compare
03f68af
to
ac40098
Compare
ac40098
to
b69fe74
Compare
e4b8285
to
286866a
Compare
dobrinyonkov
reviewed
Oct 1, 2025
286866a
to
8a9e4ab
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
Copilot reviewed 10 out of 10 changed files in this pull request and generated 3 comments.
🚀 Deployed on https://pr-12260--ui5-webcomponents-preview.netlify.app |
8a9e4ab
to
9de80e3
Compare
Add comprehensive documentation for registering and using custom illustrations in UI5 Web Components projects. Jira: BGSOFUIPIRIN-6913
- Rename registerIllustration to unsafeRegisterIllustration with security warnings - Add new registerIllustration API that accepts template functions instead of raw SVG strings - Update IllustratedMessage component to execute templates via executeTemplate() - Add IllustratedMessageTemplate support for both safe (object) and unsafe (string) variants - Update build tool to use unsafeRegisterIllustration for generated illustrations - Add comprehensive documentation for both registration methods - Create playground page demonstrating safe and unsafe approaches with working examples - Export IllustrationData and UnsafeIllustrationData types for better TypeScript support The safe variant (registerIllustration) uses template functions to prevent XSS vulnerabilities, while the unsafe variant (unsafeRegisterIllustration) maintains backward compatibility for raw SVG strings with explicit security warnings.
…tion - Restructure documentation to follow the pattern from icons guide - Clarify two registration methods: registerIllustration (recommended) vs unsafeRegisterIllustration - Add JSX template requirement note for registerIllustration method - Organize unsafeRegisterIllustration into clear Step 1 (Prepare SVG Assets) and Step 2 (Register) - Add comprehensive parameter documentation for both methods - Include examples for overriding title and subtitle texts via component properties - Update playground page with improved card layout and styling
9de80e3
to
3b5468b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds comprehensive documentation for registering custom illustrations with
ui5-illustrated-message
and introduces a safer template-based registration method.What's New
1. Safe Registration API (
registerIllustration
)npm init @ui5/webcomponents-package
. Otherwise, useunsafeRegisterIllustration
.Example:
2. Unsafe Registration API (
unsafeRegisterIllustration
)Example:
3. Documentation
4. Usage
Example: