fix: disappearing courses when changed #213
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
when a planned section/enrollment is changed, the id of that section might also change causing issues in the interface. This keeps the id stable on updates, so that the store entry (keyed by id) can be updated, rather than deleted and replaced. An alternative approach would be to update the store and make sure old values are completely deleted and new values are added with the new id -- which might be better, but require more changes Fixes #211
cmcfadden
approved these changes
Sep 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
when a planned section/enrollment is changed, the id of that section might also change causing issues in the interface in planning mode (e.g. sections that disappear after course change).
This PR updates the api id for local courses so that it's stays stable on update.
(An alternative approach would have be to update the store and make sure old values are completely deleted and new values are added with the new id -- which might be better, but would require chasing down where we're relying on an old id.)
Fixes #211