Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add api endpoints updating and showing a zlink #163

Merged
merged 5 commits into from
May 9, 2024
Merged

Add api endpoints updating and showing a zlink #163

merged 5 commits into from
May 9, 2024

Conversation

jxjj
Copy link
Contributor

@jxjj jxjj commented May 8, 2024 •
edited
Loading

Adds:

  • GET /api/v1/urls/:keyword
  • PUT /api/v1/urls/:keyword

Notes:

  • Users can only update the zlink destination url, which I think is the most typical usecase. Keyword updates are not allowed in this PR.
  • This continues with the existing signed payload in header approach that the create method uses.
  • Api docs will also need an update, but I'll do that in a separate PR if this approach looks good.

Closes #161

On dev for testing.

jxjj added 5 commits May 8, 2024 13:00
@jxjj
test that we're not trusting unsigned uid in header
f1e820c 
Z is using a JWT dance I'm unfamiliar with. I'm seeing an unsigned uid in the authorization header, while the payload is signed by a secret key. This checks that we're not trusting the unsigned uid.
@jxjj
handle missing Authorization header
6a52234
@jxjj
add show route
3b4aa1f
@jxjj
add api endpoint for updates
d0a66bd
@jxjj
tests: check that url belongs to user, check valid token
cb52c6b
@jxjj jxjj requested a review from cmcfadden May 8, 2024 22:23
cmcfadden
cmcfadden approved these changes May 9, 2024
View reviewed changes
Copy link
Member

@cmcfadden cmcfadden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

@jxjj jxjj merged commit 3c10bf5 into develop May 9, 2024
2 checks passed
@jxjj jxjj deleted the feature/161-Add-an-edit-endpoint-for-urls-in-the-API branch May 9, 2024 15:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cmcfadden cmcfadden cmcfadden approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add an edit endpoint for urls in the API?
2 participants
@jxjj @cmcfadden