Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refine 404 with contextual data #166

Merged
merged 2 commits into from
May 9, 2024

Conversation

jxjj
Copy link
Contributor

@jxjj jxjj commented May 9, 2024

Adds a bit more information to the 404 page, per #88.

@cmcfadden - were you thinking something like this? Any edits?

ScreenShot 2024-05-09 at 10 25 19@2x

Fixes #88

@jxjj jxjj requested a review from cmcfadden May 9, 2024 15:36
@jxjj jxjj self-assigned this May 9, 2024
@cmcfadden
Copy link
Member

That's more or less what I was thinking.

Maybe simplify a bit, assuming the audience won't know what Z is?

"The address <z.umn.edu/test> does not exist. Please double check the address, or contact the person who provided you with this link."

@jxjj jxjj force-pushed the feature/88-Refine-404-with-contextual-data branch from 39b100f to 2ba45ca Compare May 9, 2024 16:18
@jxjj
Copy link
Contributor Author

jxjj commented May 9, 2024

Updated:

ScreenShot 2024-05-09 at 11 18 23@2x

on dev

@jxjj jxjj merged commit 82a2c35 into develop May 9, 2024
2 checks passed
@jxjj jxjj deleted the feature/88-Refine-404-with-contextual-data branch May 9, 2024 16:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Refine 404 with contextual data
2 participants