Skip to content

Commit 51815fd

Browse files
authored
Don't exclude file objects when performing a list query and rollup is turned off, otherwise can't list children in works (#1343)
1 parent 48cd5aa commit 51815fd

File tree

1 file changed

+4
-4
lines changed

1 file changed

+4
-4
lines changed

web-access-app/src/main/java/edu/unc/lib/boxc/web/access/controllers/SearchActionController.java

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -101,7 +101,7 @@ Map<String, Object> listJson(@PathVariable("pid") String pid, HttpServletRequest
101101
SearchRequest searchRequest = generateSearchRequest(request);
102102
searchRequest.setRootPid(PIDs.get(pid));
103103
searchRequest.setApplyCutoffs(true);
104-
setDefaultRollup(searchRequest);
104+
setDefaultRollup(searchRequest, true);
105105
SearchResultResponse resultResponse = queryLayer.performSearch(searchRequest);
106106
populateThumbnailUrls(searchRequest, resultResponse);
107107
return getResults(resultResponse, "list", request);
@@ -136,7 +136,7 @@ private Map<String, Object> searchJsonRequest(HttpServletRequest request, String
136136
searchRequest.setRootPid(PIDs.get(pid));
137137
}
138138
searchRequest.setApplyCutoffs(false);
139-
setDefaultRollup(searchRequest);
139+
setDefaultRollup(searchRequest, false);
140140

141141
SearchResultResponse resultResponse = queryLayer.performSearch(searchRequest);
142142
populateThumbnailUrls(searchRequest, resultResponse);
@@ -161,12 +161,12 @@ private Map<String, Object> searchJsonRequest(HttpServletRequest request, String
161161
return getResults(resultResponse, "search", request);
162162
}
163163

164-
private void setDefaultRollup(SearchRequest searchRequest) {
164+
private void setDefaultRollup(SearchRequest searchRequest, boolean isListing) {
165165
if (searchRequest.getSearchState().getRollup() == null) {
166166
var enableRollup = shouldEnableRollup(searchRequest);
167167
LOG.debug("Rollup not specified in request, determine rollup should be set to {}", enableRollup);
168168
searchRequest.getSearchState().setRollup(enableRollup);
169-
if (!enableRollup) {
169+
if (!enableRollup && !isListing) {
170170
searchRequest.getSearchState().getResourceTypes().remove(ResourceType.File.name());
171171
}
172172
}

0 commit comments

Comments
 (0)