-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
BXC-4353 - catalog id link #1646
Conversation
agoslen
commented
Dec 22, 2023
- added template for identifiers
- for catalog id identifiers, generate link
<xsl:when test="$groupKey = 'Catalog ID'"> | ||
<xsl:variable name="catalog_number"> | ||
<xsl:choose> | ||
<xsl:when test="contains(., 'catalog.lib.unc.edu/')"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does this field ever have URLs other than catalog.lib.unc.edu? I was just wondering if it'd make sense to leave any URLs in this field untouched rather than reducing them down to an ID and then formatting it back into a URL. Then the variable would be "catalog_url" instead, and the otherwise
case would build a URL instead of a number. We don't necessary need to change this, just wondering about it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmm...not in practice but I guess in theory someone could enter a URL for the "classic catalog", for example https://afton.lib.unc.edu/record=b4386236
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@bbpennel added an alternative like what you are describing, let me know what you think
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That looks good, but i wonder if it'd work to just check for the value beginning with "http" rather than looking for specific hosts?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure!