-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Transition to NPM-packaged dependencies #266
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* upgrade-vite: Starting point for upgrading vite and vike
- axios - d3-selection - express
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a major update to the packaging style and contribution approach to this repository.
With UW-Macrostrat/web-components#62 and UW-Macrostrat/web-components#65, we now have packaged versions of all
@macrostrat
dependencies which are versioned and publicly released (see the@macrostrat
org on NPM.These include shared utilities and web components.
Usage
This change to packaging simplifies the internal structure of this application, removes its reliance on the
git submodule
workflow for shared dependencies, and streamlines the build toolchain. Unfortunately, many small UI changes will now require a multistage release process (first inweb-components
, then here).yarn link
workflow can be used to directly link to a local version of the web components, as such:yarn link -A -r ../web-components
. This will createportal:
links inpackage.json
that need to be resolved.resolve: { conditions[ 'source'] }
directive tovite.config.js
ssr.noExternal
. Eventually we may need to find a more permanent fix.Changes
@macrostrat/svg-map-components
and@corelle/svg-map-layers
modulesyarn link
andportal:
protocol