Colin Wang's Pull Request #148
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maxlou05
reviewed
Jan 25, 2025
Comment on lines
76
to
77
| distance_x = curr_position.x - self.waypoint.x | ||
| distance_y = curr_position.y - self.waypoint.y |
There was a problem hiding this comment.
It should be the other way around, target-self
|
|
||
| else: | ||
| command = commands.Command.create_set_relative_destination_command( | ||
| self.waypoint.location_x, self.waypoint.location_y |
There was a problem hiding this comment.
This is a relative distance command, so your own position would matter
| start_location.location_y - final_location.location_y | ||
| ) ** 2 | ||
|
|
||
| def within_accepepted_radius( |
| for i in range(boxes_cpu.shape[0]): | ||
| result, box = bounding_box.BoundingBox.create(boxes_cpu[i]) | ||
| if result: | ||
| bounding_boxes.append(box) |
There was a problem hiding this comment.
Normally in statistics, we would discard the entire data point (the whole image) if part of it is bad (a bounding box). (You do not need to change anything here, just something to think about)
|
|
||
| else: | ||
| command = commands.Command.create_set_relative_destination_command( | ||
| self.waypoint.location_x, self.waypoint.location_y |
There was a problem hiding this comment.
This is a relative distance command, your own position matters
maxlou05
reviewed
Jan 25, 2025
| command = commands.Command.create_land_command() | ||
|
|
||
| # find the next closest landing pad | ||
| elif self.within_accepepted_radius(report.position, self.waypoint): |
There was a problem hiding this comment.
What happens if the drone got stuck while moving from waypoint to landing pad? Currently its undefined behaviour (defaults to going to waypoint)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.