Completed tasks 1-4 for Bootcamp #88
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maxlou05
reviewed
Sep 11, 2024
| # Create BoundingBox object and append to list | ||
| result, box = bounding_box.BoundingBox.create(boxes_cpu[i]) | ||
| if result: | ||
| bounding_boxes.append(box) |
There was a problem hiding this comment.
Normally in statistics, we would discard the entire data point (the whole image) if something went wrong with it (a bounding box failed).
(You do not need to change anything, just something to think about)
| ) | ||
| elif self.stage == 1: | ||
| self.stage += 1 | ||
| closest_landing_pad_dx, closest_landing_pad_dy = 120, 120 |
There was a problem hiding this comment.
This is not going to be very reliable in the real world. Please either use float(infinity) or think of a different way you can circumvent using infinity.
There was a problem hiding this comment.
Thank you for the review! Sorry, I kind of cheated a bit because the grid is only 120 by 120. I have fixed it and used float('inf') instead.
|
Approved |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.