Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Autonomous Landing Module #235
base: main
Are you sure you want to change the base?
Autonomous Landing Module #235
Changes from 26 commits
178b772
3954351
b80e668
8b822e0
fd8241f
265cae9
6fd5f9e
8b1c536
876b714
0b07de1
38aad9b
1c5b247
398edaa
dc81d8e
af13347
6f4c829
224a7dc
c0af0dc
fb1e009
44656ad
619f8d7
fbfcc79
3bca007
3ff8098
7aa2f46
a6b98e6
e2428ef
dec4a18
1ff5d4e
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Change this to accurately get the output:
tuple[bool, AutoLandingInformation]
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reorder this so it is the first class in the file
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This method can be removed:
you dont really need the create method, just move the doc string inside the constructor.
just imagine this as a struct like in C++ to keeps things nice rather than an actual class