Cluster estimation integration test #251
Open
+154
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HermanG05
requested changes
Feb 8, 2025
Comment on lines
5
to
11
| import time | ||
| import multiprocessing as mp | ||
| from typing import List | ||
| import numpy as np | ||
| from utilities.workers import queue_proxy_wrapper, worker_controller | ||
| from modules.detection_in_world import DetectionInWorld | ||
| from modules.cluster_estimation.cluster_estimation_worker import cluster_estimation_worker |
There was a problem hiding this comment.
Ensure that your imports follow the styling convention: https://uwarg-docs.atlassian.net/wiki/spaces/CV/pages/2253226033/Python+Style+Convention
Comment on lines
28
to
32
| args=( | ||
| 3, | ||
| 0, | ||
| 3, | ||
| 0, |
There was a problem hiding this comment.
Try to store numerical constants like these at the top (ie RANDOM_STATE = 0, see other integration tests as an example).
| worker_process.start() | ||
| time.sleep(1) | ||
|
|
||
| output_results: List[List[DetectionInWorld]] = output_queue.queue.get() |
There was a problem hiding this comment.
We want to check to see if the output result is a list of ObjectInWorld, otherwise the worker wouldnt be doing anything
| input_queue.queue.put(test_data_2) | ||
| time.sleep(1) | ||
|
|
||
| output_results: List[List[DetectionInWorld]] = output_queue.queue.get() |
…G/computer-vision-python into cluster-estimation-integration-test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.