Added GSC functionality #56
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Implemented GSC transmit and removed the ISR as the driver already handles that Also renamed lastFullMessageEndIndex() to bytesUntilLastMessageEnd()
HardyYu
reviewed
May 29, 2024
HardyYu
approved these changes
Jun 9, 2024
Yaremadzulynsky
approved these changes
Jun 12, 2024
Yaremadzulynsky
added a commit
that referenced
this pull request
Jul 6, 2024
Co-authored-by: Roni Kant <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
What was completed, changed, or updated?
Implemented GSC transmit and removed the ISR as the driver already handles that.. Also renamed lastFullMessageEndIndex() to bytesUntilLastMessageEnd().
Why was this done (if applicable)?
Testing
What manual tests were used to validate the code?
What unit tests were used to validate the code?
Documentation
Milestone number and name: Milestone 2
Link to Asana task: https://app.asana.com/0/1204699115748030/1206596856283249/f
Link to Confluence documentation:
Reminders
Add reviewers to the PR
Mention the PR in the appropriate discord channel