new cluster data struct and converted lidar detection to have x, y co… #35
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Comment on lines
-13
to
-14
| __DISTANCE_LIMIT = 50 | ||
| __ANGLE_LIMIT = 170 |
| return False, None | ||
|
|
||
| if abs(angle) > cls.__ANGLE_LIMIT: | ||
| if distance == -1: |
There was a problem hiding this comment.
why only negative 1? why not keep the old check of 0 <= distance <= limit?
There was a problem hiding this comment.
the lidar driver takes care of limit checking and returns -1 if it's an invalid read. should I keep checks in both files then?
modules/lidar_detection.py
Outdated
| Angle is in degrees. | ||
| distance is in metres. | ||
| angle is in degrees. | ||
| (x, y) are the coordinates of the LiDAR scan relative to the drone's position. |
There was a problem hiding this comment.
what kind of coords? (nes, lat long, etc.)
ashum68
force-pushed
the
cluster-data-struct
branch
from
fa8f44d to
6455838
Compare
modules/lidar_detection.py
Outdated
Comment on lines
19
to
17
| Distance is in meters. | ||
| Angle is in degrees. | ||
| distance is in metres. | ||
| angle is in degrees. |
| return False, None | ||
|
|
||
| if abs(angle) > cls.__ANGLE_LIMIT: | ||
| if distance == -1: |
There was a problem hiding this comment.
why is it just -1 instead of <0?
ashum68
force-pushed
the
cluster-data-struct
branch
from
daddba5 to
fc56ee4
Compare
ashum68
force-pushed
the
cluster-data-struct
branch
from
fc56ee4 to
0152811
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ords instead of dist, angle