Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed many files to work with new common hopefully #61

Open
wants to merge 16 commits into
base: main
Choose a base branch
from

Conversation

Mmoyv27
Copy link
Contributor

@Mmoyv27 Mmoyv27 commented Dec 4, 2024

fixed many files hopefully

* Created classes to represent an oscillation of LiDAR Readings

* Fixed Linting, Created classes to represent lidar oscillations

* Adding lidar parsing and oscillation detection logic

* Added lidar_parser module

* Delete modules/lidar_oscillation.py

* Made changes based on first review

* Minor changes: break->continue if lidar_reading is None

* fixed linting for break -> continue

* Fixed Pylint Errors, function docstrings

* Fixed oscillation boundary logic

* Added Integration test based on simulated LiDAR readings

* fix minor review changes for unit tests
Copy link
Contributor

@ashum68 ashum68 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove odometry_and_waypoint.py. this is part of a separate pr. once that pr is approved and merged, we can rebase this branch with main and then it'll pass build tests.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants