-
Notifications
You must be signed in to change notification settings - Fork 3
Optimization with Time Flag #60
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Changes from all commits
0984325
a1b73cc
49affdf
575cd8d
af11966
5449426
a966fa2
399c18f
84d6b01
0f5b974
b03d046
51e1245
4a0b6fb
3350703
15dac5b
737ed40
1d8013f
6b04f7b
813e10b
92d8982
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -228,6 +228,19 @@ class Vec3 { | |
| Mat3 OuterProduct(const Vec3 &) const; | ||
| }; | ||
|
|
||
| /** | ||
| * Represents Earth-Centered, Earth-Fixed (ECEF) coordinates. | ||
| * | ||
| * ECEF is a Cartesian coordinate system with its origin at Earth's center. | ||
| * The axes are: | ||
| * - x-axis: Points to the intersection of the equator and prime meridian (0° latitude, 0° longitude) | ||
| * - y-axis: Points to 90°E longitude on the equator (0° latitude, 90°E longitude) | ||
| * - z-axis: Points to the North Pole (90°N latitude) | ||
| * | ||
| * All coordinates are in meters. | ||
| */ | ||
| typedef Vec3 ECEFCoordinates; | ||
|
Collaborator
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. At this point, it probably belongs in style.hpp instead (or possibly the output file, but you should defend either decision you make). Alternately, you could forgo ECEFCoordinates altogether and just use Vec3. The primary reason I use typedefs is to clarify what kind of info is being fed between and as an output from each pipeline, but this is not one of those data types. You could still keep the typedef, but also defend that decision as well.
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Since Quaternion is also defined in Additionally, I do think it may be beneficial to keep a typedef ECEFCoordinates because I believe it would be confusing if we are converting between multiple types of coordinate points and all of them are defined with a Vec3. |
||
|
|
||
| /////////////////////////////////// | ||
| ///// VECTOR UTILITY FUNCTIONS //// | ||
| /////////////////////////////////// | ||
|
|
||
Uh oh!
There was an error while loading. Please reload this page.