Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Xinghao Li Onboarding #6

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Xinghao Li Onboarding #6

wants to merge 1 commit into from

Conversation

Gogo-XD
Copy link

@Gogo-XD Gogo-XD commented Jan 22, 2025

Purpose

Completed the GS on-boarding task. Include a screenshot of the front-end of the application.

New Changes

  • Completed validate_params_format to ensure the params are in the correct formatting
  • Completed methods to create and deleted commands
  • Completed middle logging

Testing

  • pytest - 100% passed
    image

@Yarik-Popov Yarik-Popov changed the title feat: completed onboarding Ximghao Li Onboarding Jan 23, 2025
@Yarik-Popov Yarik-Popov changed the title Ximghao Li Onboarding Xinghao Li Onboarding Jan 23, 2025
Yarik-Popov
Yarik-Popov reviewed Jan 23, 2025
View reviewed changes
Copy link
Contributor

@Yarik-Popov Yarik-Popov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm. You are done the backend portion of the onboarding.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Yarik-Popov Yarik-Popov Yarik-Popov left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Gogo-XD @Yarik-Popov