Completed Onboarding #207
Open
Completed Onboarding #207
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kepler452b123
requested changes
Jan 23, 2025
lm75bd/lm75bd.c
Outdated
| @@ -28,6 +28,28 @@ error_code_t lm75bdInit(lm75bd_config_t *config) { | |||
| error_code_t readTempLM75BD(uint8_t devAddr, float *temp) { | |||
| /* Implement this driver function */ | |||
|
|
|||
| error_code_t errCode; | |||
There was a problem hiding this comment.
don't need this in this function
services/thermal_mgr/thermal_mgr.c
Outdated
Comment on lines
55
to
57
| if (xQueueSend(thermalMgrQueueHandle, event, 0) == pdTRUE){ | ||
| return ERR_CODE_QUEUE_FULL; | ||
| } |
There was a problem hiding this comment.
this should be if its not pdTRUE (queue is full if it fails)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Explain the purpose of the PR here, including references to any existing Notion tasks.
New Changes
Testing
Outstanding Changes