Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed cached wildcard queries #176

Merged
merged 1 commit into from
Jan 16, 2025
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion jecs.luau
Original file line number Diff line number Diff line change
Expand Up @@ -619,7 +619,7 @@ local function archetype_create(world: World, id_types: { i24 }, ty, prev: i53?)
end
end

for _, id in id_types do
for id in records do
local observer_list = find_observers(world, EcsOnArchetypeCreate, id)
if not observer_list then
continue
Expand Down
69 changes: 67 additions & 2 deletions test/tests.luau
Original file line number Diff line number Diff line change
Expand Up @@ -1433,13 +1433,13 @@ TEST("change tracking", function()
local i = 0
for entity, number in q1 do
i += 1
world:add(testEntity, tag)
world:add(testEntity, tag)
end

CHECK(i == 1)

for e, n in q1 do
world:set(e, pair(previous, component), n)
world:set(e, pair(previous, component), n)
end
end

Expand Down Expand Up @@ -1594,4 +1594,69 @@ TEST("repro", function()
CHECK(counter == 0)
end
end)

TEST("wildcard query", function()
do CASE "#1"
local world = world_new()
local pair = jecs.pair

local Relation = world:entity()
local Wildcard = jecs.Wildcard
local A = world:entity()

local relationship = pair(Relation, Wildcard)
local query = world:query(relationship):cached()

local entity = world:entity()

world:add(entity, pair(Relation, A))

local counter = 0
for e in query:iter() do
counter += 1
end
CHECK(counter == 1)
end
do CASE "#2"
local world = world_new()
local pair = jecs.pair

local Relation = world:entity()
local Wildcard = jecs.Wildcard
local A = world:entity()

local relationship = pair(Relation, Wildcard)

local entity = world:entity()

world:add(entity, pair(Relation, A))

local counter = 0
for e in world:query(relationship):iter() do
counter += 1
end
CHECK(counter == 1)
end
do CASE "#3"
local world = world_new()
local pair = jecs.pair

local Relation = world:entity()
local Wildcard = jecs.Wildcard
local A = world:entity()

local entity = world:entity()

world:add(entity, pair(Relation, A))

local relationship = pair(Relation, Wildcard)
local query = world:query(relationship):cached()

local counter = 0
for e in query:iter() do
counter += 1
end
CHECK(counter == 1)
end
end)
FINISH()
Loading