-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Testing framework #160
Testing framework #160
Conversation
This is looking really good! Thanks for your efforts. As a broader point (you don't have to address this right now), I think we need to decide whether the status vars using randomisation should dump their randomly generated values somewhere as artifacts to make it easier to debug if something goes wrong. Alternatively, it could be easier to randomly generate seeds and store the seeds as artifacts. |
Thanks! Yes, dumping status variables would be good. However, I have commented out the tests that randomize the status variables because they break some modules. |
@astropiuu can you check why the tests are failing? |
…to testing_framework
Looks good as an initial framework. Just need to use qudi-core from ulm-iqo rather than my fork. Also need a pyproject.toml to be added to qudi-iqo-modules. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work! This can be merged.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tests pass with the pyproject.toml merged from PR #185 so we should be good to go. Can be merged!
Testing framework based on pytest that would run on GitHub Actions
Description
The PR includes
This pyproject.toml is based on @Neverhorst 's PR in qudi-core
Some tests which fail have been commented out and opened as issues.
Motivation and Context
The testing framework would assist in identifying whether any new changes break the current functionality.
So far, the tests written cover loading of all modules, resetting status variables, modifying status variables, and unit testing for the Odmr Logic module.
How Has This Been Tested?
The framework has been tested on a fork repository using the same test workflow
Types of changes
The PR only changes the pyproject.toml and setup.py files
The rest of the newly added files are part of testing and do not modify any existing code
Checklist:
/docs/changelog.md
.(syntax, indentation, mutable default values, etc.).