Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Polish profiles page #1116

Merged
merged 17 commits into from
Jan 15, 2025
Merged

Polish profiles page #1116

merged 17 commits into from
Jan 15, 2025

Conversation

hmpf
Copy link
Contributor

@hmpf hmpf commented Jan 9, 2025

For many of the tasks in #1110

Copy link

github-actions bot commented Jan 9, 2025

Test results

   10 files  1 050 suites   37m 59s ⏱️
  532 tests   531 ✅  1 💤 0 ❌
5 320 runs  5 310 ✅ 10 💤 0 ❌

Results for commit 04e064e.

♻️ This comment has been updated with latest results.

@codecov-commenter
Copy link

codecov-commenter commented Jan 9, 2025

Codecov Report

Attention: Patch coverage is 29.03226% with 22 lines in your changes missing coverage. Please review.

Project coverage is 79.71%. Comparing base (d3e7861) to head (9cde3ff).
Report is 18 commits behind head on master.

Files with missing lines Patch % Lines
src/argus/htmx/notificationprofile/views.py 35.00% 13 Missing ⚠️
src/argus/htmx/widgets.py 18.18% 9 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1116      +/-   ##
==========================================
- Coverage   80.02%   79.71%   -0.32%     
==========================================
  Files         141      141              
  Lines        5257     5285      +28     
==========================================
+ Hits         4207     4213       +6     
- Misses       1050     1072      +22     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@hmpf hmpf force-pushed the polish-profiles-page branch from 1480f56 to c77ae96 Compare January 13, 2025 11:01
@hmpf hmpf requested review from podliashanyk and a team January 14, 2025 09:15
@hmpf hmpf marked this pull request as ready for review January 14, 2025 09:18
@johannaengland
Copy link
Contributor

Would be nice to have a news fragment as well

@hmpf hmpf force-pushed the polish-profiles-page branch from 04e064e to 9cde3ff Compare January 15, 2025 13:23
Copy link

@hmpf hmpf merged commit f1ecafa into master Jan 15, 2025
14 of 15 checks passed
@hmpf hmpf deleted the polish-profiles-page branch January 15, 2025 13:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

6 participants