Make "add time recurrence" button#1280
Draft
hmpf wants to merge 35 commits intoUninett:original-improve-timeslots-pagefrom
Draft
Make "add time recurrence" button#1280hmpf wants to merge 35 commits intoUninett:original-improve-timeslots-pagefrom
hmpf wants to merge 35 commits intoUninett:original-improve-timeslots-pagefrom
Conversation
--------- Co-authored-by: Johanna England <johanna.england@sikt.no>
hmpf
force-pushed
the
make-add-timerecurrnce-button
branch
2 times, most recently
from
3227890 to
6c6912d
Compare
Missing: Theme-ability so that it is always visible in all themes. Needs user feedback on: Visibilty/thickness for kiosk mode/big screen
Primary in incident list page, color type not set elsewhere.
Mark v1 as deprecated in the OpenAPI schema. * Deprecate all V1 views that differ from V2 * Deprecate V1 views that do not differ from V2 Turns out it is necessary to subclass views to make the `deprecated` attribute mark the correct view. --------- Co-authored-by: Johanna England <johanna.england@sikt.no>
This should make it so it no longer shows an error message if you enter a tag that doesnt match any existing incidents. Instead you will get an empty list of incidents.
Per now it only contains Name field. But in case more fields will be added, they will be styled as text field. This can easily be changed via widget tweaks if needed.
.. with the help of widget tweaks
Makes it so you have to type in HH:MM format with little help other than placeholder. type=time is nicer, but depending on the local language of your computer it might show 24h or AM/PM. We want to avoid AM/PM at pretty much all costs so we use this basic field for selecting time with goal of making something nicer later that will be reused other places.
.. using further improvements to TimeRecurrence.__str__
Otherwise the last message won't (I know, nitpick)
Partially fixes a bug with days dropdown not being updated on user interaction. More to come.
For some reason, when going from zero to more than zero recurrences after deleting a timeslot's single recurrence, running a database query didn't actually fetch the new recurrences but an empty queryset... WAT.
Jam session.
hmpf
force-pushed
the
make-add-timerecurrnce-button
branch
from
6c6912d to
7027f34
Compare
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Scope and purpose
Fixes #1275
Contributor Checklist
Every pull request should have this checklist filled out, no matter how small it is.
More information about contributing to Argus can be found in the
Development docs.