Draft
Conversation
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1324 +/- ##
==========================================
+ Coverage 78.76% 79.47% +0.71%
==========================================
Files 141 141
Lines 5763 5763
==========================================
+ Hits 4539 4580 +41
+ Misses 1224 1183 -41 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
hmpf
reviewed
Mar 31, 2025
| duration = now - start_time | ||
| with patch("argus.htmx.incident.views.tznow", return_value=now): | ||
| response = incident_detail(self.request, incident.pk) | ||
| self.assertContains(response, str(duration)) |
Contributor
There was a problem hiding this comment.
Duration isn't styled properly yet so this is a temporary check. When it is styled properly I would like a generalized (ISO!) duration as well which can be used for checking the logic.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Scope and purpose
Fixes #1323.
Had troubles getting the Django test client stuff working, so this is example of how my tests look using
RequestFactoryand testing the views directly.I have not yet figured out how to test htmx specific stuff, like first loading a page, then doing a htmx request to change only a portion of the site and assert that only that portion was updated.
The tests here are more normal tests, checking that values are correct for get requests, http codes, and that stuff is updated correctly in the database for create/update views. These tests are needed as well, but it doesnt really test the htmx functionality itself
This pull request
Contributor Checklist
Every pull request should have this checklist filled out, no matter how small it is.
More information about contributing to Argus can be found in the
Development docs.