Skip to content

Conversation

@Simrayz
Copy link
Contributor

@Simrayz Simrayz commented Oct 8, 2025

Scope and purpose

Refactors styleguide to improve layout, spacing and typography.

image

Contributor Checklist

Every pull request should have this checklist filled out, no matter how small it is.
More information about contributing to Argus can be found in the
Development docs.

  • Added a changelog fragment for towncrier
  • Added/amended tests for new/changed code
  • Added/changed documentation, including updates to the user manual if feature flow or UI is considerably changed
  • Linted/formatted the code with ruff and djLint, easiest by using pre-commit
  • The first line of the commit message continues the sentence "If applied, this commit will ...", starts with a capital letter, does not end with punctuation and is 50 characters or less long. See our how-to
  • If applicable: Created new issues if this PR does not fix the issue completely/there is further work to be done
  • If this results in changes in the UI: Added screenshots of the before and after
  • If this results in changes to the database model: Updated the ER diagram

@Simrayz Simrayz requested a review from hmpf October 8, 2025 12:24
@Simrayz Simrayz self-assigned this Oct 8, 2025
@Simrayz Simrayz added the nonews No news fragment is necessary for this PR (e.g. refactoring, cleanups, workflow/development changes) label Oct 8, 2025
@Simrayz Simrayz force-pushed the add-styleguide-simen branch from 4385cdf to a7903fe Compare October 8, 2025 12:26
@Simrayz Simrayz force-pushed the add-styleguide-simen branch from a7903fe to c000a93 Compare October 8, 2025 12:27
@sonarqubecloud
Copy link

sonarqubecloud bot commented Oct 8, 2025

@github-actions
Copy link

github-actions bot commented Oct 8, 2025

Test results

    4 files    468 suites   17m 31s ⏱️
  565 tests   564 ✅ 1 💤 0 ❌
2 260 runs  2 256 ✅ 4 💤 0 ❌

Results for commit c000a93.

@codecov
Copy link

codecov bot commented Oct 8, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 78.30%. Comparing base (09fe53d) to head (c000a93).
⚠️ Report is 1 commits behind head on add-styleguide.

Additional details and impacted files
@@               Coverage Diff               @@
##           add-styleguide    #1559   +/-   ##
===============================================
  Coverage           78.30%   78.30%           
===============================================
  Files                 125      125           
  Lines                5513     5513           
===============================================
  Hits                 4317     4317           
  Misses               1196     1196           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

<div class="space-y-2">
<h3 id="form-default-rendering" class="text-xl">Default rendering</h3>
<p>
The form blow is for testing the look and feel of forms. Submitting will re-render the form with the submitted values pre-filled. Click "Reset" to empty the fields.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
The form blow is for testing the look and feel of forms. Submitting will re-render the form with the submitted values pre-filled. Click "Reset" to empty the fields.
The form below is for testing the look and feel of forms. Submitting will re-render the form with the submitted values pre-filled. Click "Reset" to empty the fields.

Probably my typo but still needs fixing!

@hmpf hmpf merged commit 9c3c727 into add-styleguide Oct 9, 2025
16 checks passed
@hmpf hmpf deleted the add-styleguide-simen branch October 9, 2025 08:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

nonews No news fragment is necessary for this PR (e.g. refactoring, cleanups, workflow/development changes)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants