Skip to content

PoC: Refactor Argus Filter UI#1693

Open
Simrayz wants to merge 6 commits intomainfrom
experiment/argus-filter-ui-refactor
Open

PoC: Refactor Argus Filter UI#1693
Simrayz wants to merge 6 commits intomainfrom
experiment/argus-filter-ui-refactor

Conversation

@Simrayz
Copy link
Contributor

@Simrayz Simrayz commented Jan 8, 2026

Scope and purpose

Refactor the incident list filter UI based on user feedback requesting a more compact interface and collapsible filters:

  • Replace the tabbed "Filter Incidents" / "Update Incidents" interface with a collapsible filterbox and a
    dynamic bulk actions bar
  • Filterbox is hidden by default and toggled via a "Show/Hide filters" button
  • Bulk actions only appear when rows are selected, reducing visual noise
  • Extract toolbar into a new _incident_toolbar.html template and deprecate _incident_list_menubar.html for
    backwards compatibility

Screenshots

image image image

Contributor Checklist

Every pull request should have this checklist filled out, no matter how small it is.
More information about contributing to Argus can be found in the
Development docs.

  • Added a changelog fragment for towncrier
  • Added/amended tests for new/changed code
  • Added/changed documentation, including updates to the user manual if feature flow or UI is considerably changed
  • Linted/formatted the code with ruff and djLint, easiest by using pre-commit
  • The first line of the commit message continues the sentence "If applied, this commit will ...", starts with a capital letter, does not end with punctuation and is 50 characters or less long. See our how-to
  • If applicable: Created new issues if this PR does not fix the issue completely/there is further work to be done
  • If this results in changes in the UI: Added screenshots of the before and after
  • If this results in changes to the database model: Updated the ER diagram

@Simrayz Simrayz self-assigned this Jan 8, 2026
@Simrayz Simrayz added frontend Affects frontend filter Affects the Filter-model, incident list query parameters or both labels Jan 8, 2026
@Simrayz Simrayz changed the title Experiment: Refactor Argus Filter UI PoC: Refactor Argus Filter UI Jan 8, 2026
@github-actions
Copy link

github-actions bot commented Jan 8, 2026

Test results

    6 files    834 suites   1m 45s ⏱️
  657 tests   656 ✅ 1 💤 0 ❌
3 942 runs  3 936 ✅ 6 💤 0 ❌

Results for commit 73496b8.

♻️ This comment has been updated with latest results.

@Simrayz Simrayz force-pushed the experiment/argus-filter-ui-refactor branch from 2fe1c19 to b4441e9 Compare January 8, 2026 13:13
@codecov
Copy link

codecov bot commented Jan 8, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 80.46%. Comparing base (61b2109) to head (73496b8).
⚠️ Report is 8 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1693   +/-   ##
=======================================
  Coverage   80.46%   80.46%           
=======================================
  Files         135      135           
  Lines        6399     6399           
=======================================
  Hits         5149     5149           
  Misses       1250     1250           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@Simrayz Simrayz force-pushed the experiment/argus-filter-ui-refactor branch 2 times, most recently from 28ddd3b to 1d72359 Compare January 8, 2026 14:26
@Simrayz Simrayz requested a review from a team January 8, 2026 14:26
@Simrayz Simrayz marked this pull request as ready for review January 8, 2026 14:26
Copy link
Contributor

@johannaengland johannaengland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seth Meyers Love it

@hmpf
Copy link
Contributor

hmpf commented Jan 21, 2026

When I update/delete a filter the dropdown is underneath the incident list again.

@hmpf
Copy link
Contributor

hmpf commented Jan 21, 2026

I would prefer the opportunity to be able to keep the old way, that is: filters shown by default. This could be a user preference.

@hmpf hmpf self-requested a review January 21, 2026 13:26
Copy link
Contributor

@hmpf hmpf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs checking:

Possibly z-index shenanigans again.

Not blocking, but eeeh:

I would prefer the hiding of the filters to be opt-in (frankly I'd prefer hiding the "alter named filters" box).

@Simrayz Simrayz force-pushed the experiment/argus-filter-ui-refactor branch from 1d72359 to cc66d18 Compare January 21, 2026 17:07
@sonarqubecloud
Copy link

@github-project-automation github-project-automation bot moved this from 📋 Backlog to ♻ Changes requested in Argus development, public Jan 22, 2026
@hmpf hmpf added the rc-future label Jan 22, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

filter Affects the Filter-model, incident list query parameters or both frontend Affects frontend rc-future

Projects

Status: Changes requested

Development

Successfully merging this pull request may close these issues.

3 participants