Conversation
Test results 6 files 810 suites 1m 36s ⏱️ Results for commit 6062b9e. ♻️ This comment has been updated with latest results. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1714 +/- ##
=======================================
Coverage 80.22% 80.22%
=======================================
Files 133 133
Lines 6271 6271
=======================================
Hits 5031 5031
Misses 1240 1240 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Is this change for the build pipeline only, or will you run |
|
This is for the build pipeline only. Note that the "tailwind" rule in the Makefile has changed to once again have |
|
I was thinking I'd only build on change with proper Makefile magic but for a build artifact it is always OK to build it fresh for every version. When running When I build packages I do it in a clean repo where no watchers are running, for various paranoid reasons. |
acceefe to
046e44f
Compare
046e44f to
b82c23b
Compare
Simrayz
left a comment
There was a problem hiding this comment.
The modified/new rules don't really work for me (on macOS) due to naming/version conflicts. Is the build environment different in this regard?
| tailwindcli: | ||
| @which tailwind || echo "tailwindcss not in path" | ||
|
|
||
| tailwind: tailwindcli |
There was a problem hiding this comment.
After removing the $(TAILWINDDIR)/ prefix, it no longer uses the specific version for this project. My global tailwindcss is version 4, while the repo uses tailwind 3, so I get an error when trying to run make build. I think the build pipeline should also use make upgrade-tailwind or at least make sure to install the current defined version.
There was a problem hiding this comment.
Fixed, but this doesn't do anything to the one in $PATH
There was a problem hiding this comment.
How does macOS handle $PATH?
|



Scope and purpose
Fixes #1712
For this to work, "tailwindcss" must be in PATH. How to set PATH is OS and distro dependent.
This pull request
Contributor Checklist
Every pull request should have this checklist filled out, no matter how small it is.
More information about contributing to Argus can be found in the
Development docs.
[ ] Added/amended tests for new/changed code[ ] Linted/formatted the code with ruff and djLint, easiest by using pre-commit[ ] If this results in changes in the UI: Added screenshots of the before and after[ ] If this results in changes to the database model: Updated the ER diagram