Skip to content

Add filter scope preview to planned maintenance form#1770

Draft
Simrayz wants to merge 2 commits intomainfrom
feat/1765-add-preview-of-the-scope-of-filters-attached-to-a-pm-task
Draft

Add filter scope preview to planned maintenance form#1770
Simrayz wants to merge 2 commits intomainfrom
feat/1765-add-preview-of-the-scope-of-filters-attached-to-a-pm-task

Conversation

@Simrayz
Copy link
Contributor

@Simrayz Simrayz commented Jan 26, 2026

Scope and purpose

Resolves #1765

This PR adds a preview of incidents that are covered by the currently selected filters in the Planned Maintenance form.
This should give a good indication of the extent of the maintenance task, to avoid accidentally generating too many notifications.

Screenshots

image

Contributor Checklist

Every pull request should have this checklist filled out, no matter how small it is.
More information about contributing to Argus can be found in the
Development docs.

  • Added a changelog fragment for towncrier
  • Added/amended tests for new/changed code
  • Added/changed documentation, including updates to the user manual if feature flow or UI is considerably changed
  • Linted/formatted the code with ruff and djLint, easiest by using pre-commit
  • The first line of the commit message continues the sentence "If applied, this commit will ...", starts with a capital letter, does not end with punctuation and is 50 characters or less long. See our how-to
  • If applicable: Created new issues if this PR does not fix the issue completely/there is further work to be done
  • If this results in changes in the UI: Added screenshots of the before and after
  • If this results in changes to the database model: Updated the ER diagram

@Simrayz Simrayz added HTMx Views, urls, templates... frontend Affects frontend planned maintenance labels Jan 26, 2026
@Simrayz Simrayz self-assigned this Jan 26, 2026
@Simrayz Simrayz requested a review from a team January 26, 2026 10:34
@github-actions
Copy link

github-actions bot commented Jan 26, 2026

Test results

    6 files    894 suites   1m 58s ⏱️
  704 tests   703 ✅ 1 💤 0 ❌
4 224 runs  4 218 ✅ 6 💤 0 ❌

Results for commit 9e96035.

♻️ This comment has been updated with latest results.

@codecov
Copy link

codecov bot commented Jan 26, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 82.68%. Comparing base (7f6da04) to head (9e96035).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1770      +/-   ##
==========================================
+ Coverage   82.57%   82.68%   +0.11%     
==========================================
  Files         137      137              
  Lines        6552     6574      +22     
==========================================
+ Hits         5410     5436      +26     
+ Misses       1142     1138       -4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@Simrayz Simrayz force-pushed the feat/1765-add-preview-of-the-scope-of-filters-attached-to-a-pm-task branch from f64adb9 to 36163ff Compare January 26, 2026 11:57
@Simrayz Simrayz force-pushed the feat/1765-add-preview-of-the-scope-of-filters-attached-to-a-pm-task branch from 36163ff to 9e96035 Compare January 26, 2026 12:27
@sonarqubecloud
Copy link

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

frontend Affects frontend HTMx Views, urls, templates... planned maintenance

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Suggestion: Show also the filterblob in planned maintenance detail view so that users know what this filter actually contains

1 participant