Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wipe out UI state on manual reload #106

Merged
merged 2 commits into from
Jun 7, 2024

Conversation

podliashanyk
Copy link
Contributor

@podliashanyk podliashanyk commented May 30, 2024

Closes #100

Implemented changes:

Every time the events page is initially loaded, or manually reloaded, the UI state is cleared:

  • checked (selected) rows become unchecked
  • expanded rows collapse
  • any existing error alerts are removed
  • list with IDs of current events is cleared (not visible in the UI, related to NTIE table refresh in Table refresh with ntie #87)

@podliashanyk podliashanyk added bug Something isn't working beta Part of beta release labels May 30, 2024
@podliashanyk podliashanyk self-assigned this May 30, 2024
Copy link

Test results

  4 files    4 suites   8s ⏱️
14 tests 14 ✔️ 0 💤 0
56 runs  56 ✔️ 0 💤 0

Results for commit 705b502.

@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 14.28571% with 6 lines in your changes are missing coverage. Please review.

Please upload report for BASE (main@ec4cc21). Learn more about missing BASE report.

Files Patch % Lines
src/howitz/endpoints.py 14.28% 6 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main     #106   +/-   ##
=======================================
  Coverage        ?   50.18%           
=======================================
  Files           ?       15           
  Lines           ?      811           
  Branches        ?        0           
=======================================
  Hits            ?      407           
  Misses          ?      404           
  Partials        ?        0           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@podliashanyk podliashanyk merged commit fedf6d3 into main Jun 7, 2024
5 checks passed
@podliashanyk podliashanyk deleted the wipe-out-ui-state-on-manual-reload branch June 7, 2024 08:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
beta Part of beta release bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

State of UI components differs from state in the app after user manually reloads page
3 participants