Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve clarity and usability of README for first-time Howitz users #86
Improve clarity and usability of README for first-time Howitz users #86
Changes from 30 commits
80f5413
1044407
64f773f
81b3489
bba85db
ac9f5f1
a3566da
75af5a2
6bcf615
86af3b1
53c29c7
c1fd048
0de11d2
c492252
ee5af75
2c7366b
1b61ab8
15185b2
090a1ea
2bf3e84
b3f8ad9
7692e0a
6188a8e
b5211da
2b2089c
acbc9f6
49d0588
cede3c9
bc9f999
bcbcf69
5a5b366
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would add this:
They are not used unless the
[logging.loggers.MODULE]
-stuff is also included.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This seems to clutter the minimal file. Don't really see the reason to include it especially since it will not be activated unless
[logging.loggers.MODULE]
-stuff is included.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What's
devmode
do? Doesn't sound very production-y to me...There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
devmode
is primarily used for flask app configuration. Values for flask server address and flask storage location will have reasonable dev defaults ifdevmode
isTrue
and are empty otherwise. @hmpf are there any other use cases fordevmode
in Howitz?Good point, it shouldn't be set to true in example config without additional changes! Will fix.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We tried adding a cli-flag
devmode
to make it very explicit when running for development: debug is set to True as well as some other things. But we stopped trying to support it as a cli-flag and now keep it only in the config-file because making it work withflask --app howitz run
was proving too hard/not worth the effort.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Have added warnings in the
README
about checking out the "Config file for production"-section when configuring Howitz for prod.But I have a mild suspicion that the mentioned "Config file for production"-section is somewhat incomplete. Have created #109