Skip to content

Conversation

@johannaengland
Copy link
Contributor

@johannaengland johannaengland commented Sep 13, 2024

Scope and purpose

The version 1.1.6 breaks. Versions 1.0.0 to 1.1.5 and the newest version 1.1.7 work.

This pull request

  • changes a dependency

Contributor Checklist

Every pull request should have this checklist filled out, no matter how small it is.
More information about contributing to Zino can be found in the
README.

  • Added a changelog fragment for towncrier
  • Added/amended tests for new/changed code
  • Added/changed documentation
  • Linted/formatted the code with black, ruff and isort, easiest by using pre-commit
  • The first line of the commit message continues the sentence "If applied, this commit will ...", starts with a capital letter, does not end with punctuation and is 50 characters or less long. See https://cbea.ms/git-commit/
  • If applicable: Created new issues if this PR does not fix the issue completely/there is further work to be done

@johannaengland johannaengland added the dependencies Pull requests that update a dependency file label Sep 13, 2024
@johannaengland johannaengland self-assigned this Sep 13, 2024
@codecov
Copy link

codecov bot commented Sep 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.66%. Comparing base (0ac7e5d) to head (d39e921).
Report is 2 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #370   +/-   ##
=======================================
  Coverage   98.66%   98.66%           
=======================================
  Files          77       77           
  Lines        9715     9715           
=======================================
  Hits         9585     9585           
  Misses        130      130           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@johannaengland johannaengland changed the title Constrain snmpsim version to <1.1.6 Constrain snmpsim version to !=1.1.6 Sep 13, 2024
@johannaengland johannaengland changed the title Constrain snmpsim version to !=1.1.6 Constrain snmpsim version to not 1.1.6 Sep 13, 2024
@sonarqubecloud
Copy link

@lunkwill42 lunkwill42 added the nonews No news fragment is necessary for this PR (e.g. refactoring, cleanups, workflow/development changes) label Mar 11, 2025
The version 1.1.6 breaks, so this is making sure that one is not used
@sonarqubecloud
Copy link

@johannaengland johannaengland merged commit 7270351 into Uninett:master Mar 11, 2025
9 checks passed
@johannaengland johannaengland deleted the pin-snmpsim branch March 11, 2025 07:36
lunkwill42 added a commit that referenced this pull request Mar 13, 2025
Version 1.1.6 specifically breaks things.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependencies Pull requests that update a dependency file nonews No news fragment is necessary for this PR (e.g. refactoring, cleanups, workflow/development changes)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants