-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: js-packages structure #1054
Conversation
import {makeNames} from '@unique/test-utils/util.js'; | ||
|
||
const {dirname} = makeNames(import.meta.url); | ||
const EVM_ABI_DIR = `${dirname}/../../../evm-abi`; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
const EVM_ABI_DIR = `${dirname}/../../../evm-abi`; | |
const EVM_ABI_DIR = await import.meta.resolve('@unique/evm-abi'); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Оно, видимо, с воркспейсами не работает
Error: Cannot find package '/home/ubuntu/vscode-remote/unique-chain/js-packages/node_modules/@unique-nft/evm-abi/'
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Это typescript жалуется, или node.js? Node.js по идее не должен, оно работает точно с такими же резолюциями как и просто import же
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Нода, т.к. уже при запуске тестов это происходит, в рантайме.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
И это странно, ведь у нас не транспилирует импорты, а их резолвит
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
А через импорты выходит evm-abi использовать?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Через импорты выходит, см #js-packages/test-utils/eth/index.ts
927de33
to
8ba76b1
Compare
8ba76b1
to
4da0499
Compare
New evm-abi package
Remove old zombienet migrations
Move eth playgrounds to test-utils
Remove all dependencies on "@unique/tests"