Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove duplicate 'static bound in rpc::create_full #1056

Merged

Conversation

JarvisCraft
Copy link
Contributor

Description

This removes the duplicate 'static bound on generic parameter of unique-node::rpc::create_full(..).

@PraetorP PraetorP requested a review from CertainLach March 11, 2024 09:25
@CertainLach
Copy link
Member

CertainLach commented Mar 11, 2024

Apparently, наши экшоны не работают когда ветка находится в чужом репозитории
Это к @BuddyGlas, было бы неплохо чот исправить на будущее.

По идее тут ничего в коде не должно сломаться, поэтому принимаю

@CertainLach CertainLach reopened this Mar 11, 2024
@CertainLach
Copy link
Member

Нет, не принимаю, @JarvisCraft отребейзи на develop

@JarvisCraft JarvisCraft force-pushed the remove-duplicate-static-bound branch from 8157c83 to d3e0af2 Compare March 11, 2024 16:43
@JarvisCraft JarvisCraft changed the base branch from master to develop March 11, 2024 16:43
@JarvisCraft
Copy link
Contributor Author

@CertainLach, готово

@CertainLach CertainLach merged commit f29e16f into UniqueNetwork:develop Mar 11, 2024
@JarvisCraft JarvisCraft deleted the remove-duplicate-static-bound branch March 11, 2024 17:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants