fix: the v3 core factory for some chains #12
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jsy1218
added a commit
to Uniswap/smart-order-router
that referenced
this pull request
Apr 19, 2024
- **What kind of change does this PR introduce?** (Bug fix, feature, docs update, ...) Big fix - **What is the current behavior?** (You can also link to an open issue here) Since shadow quoting in Base today (Uniswap/routing-api#598), the accuracy has been low:  I used tenderly [simulation](https://www.tdly.co/shared/simulation/cf37f5ed-5eaf-49f6-b966-fc33c10e0748) to debug, then I noticed the computed pool address from the view-only quoter is non-existent on Base. I was using the wrong v3 core factory when deploying to Base. I already fixed that and re-deployed Uniswap/view-quoter-v3#12, but we also need to update the quoter deploy address in SOR, so that routing-api quote accuracy can go up on Base. - **What is the new behavior (if this is a feature change)?** Update [quoter](https://basescan.org/address/0x222cA98F00eD15B1faE10B61c277703a194cf5d2#code) address - **Other information**:
jsy1218
added a commit
to Uniswap/smart-order-router
that referenced
this pull request
May 9, 2024
- **What kind of change does this PR introduce?** (Bug fix, feature, docs update, ...) Big fix - **What is the current behavior?** (You can also link to an open issue here) Since shadow quoting in Base today (Uniswap/routing-api#598), the accuracy has been low:  I used tenderly [simulation](https://www.tdly.co/shared/simulation/cf37f5ed-5eaf-49f6-b966-fc33c10e0748) to debug, then I noticed the computed pool address from the view-only quoter is non-existent on Base. I was using the wrong v3 core factory when deploying to Base. I already fixed that and re-deployed Uniswap/view-quoter-v3#12, but we also need to update the quoter deploy address in SOR, so that routing-api quote accuracy can go up on Base. - **What is the new behavior (if this is a feature change)?** Update [quoter](https://basescan.org/address/0x222cA98F00eD15B1faE10B61c277703a194cf5d2#code) address - **Other information**:
jsy1218
added a commit
to Uniswap/smart-order-router
that referenced
this pull request
May 9, 2024
- **What kind of change does this PR introduce?** (Bug fix, feature, docs update, ...) Big fix - **What is the current behavior?** (You can also link to an open issue here) Since shadow quoting in Base today (Uniswap/routing-api#598), the accuracy has been low:  I used tenderly [simulation](https://www.tdly.co/shared/simulation/cf37f5ed-5eaf-49f6-b966-fc33c10e0748) to debug, then I noticed the computed pool address from the view-only quoter is non-existent on Base. I was using the wrong v3 core factory when deploying to Base. I already fixed that and re-deployed Uniswap/view-quoter-v3#12, but we also need to update the quoter deploy address in SOR, so that routing-api quote accuracy can go up on Base. - **What is the new behavior (if this is a feature change)?** Update [quoter](https://basescan.org/address/0x222cA98F00eD15B1faE10B61c277703a194cf5d2#code) address - **Other information**:
jsy1218
added a commit
to Uniswap/smart-order-router
that referenced
this pull request
May 10, 2024
- **What kind of change does this PR introduce?** (Bug fix, feature, docs update, ...) Big fix - **What is the current behavior?** (You can also link to an open issue here) Since shadow quoting in Base today (Uniswap/routing-api#598), the accuracy has been low:  I used tenderly [simulation](https://www.tdly.co/shared/simulation/cf37f5ed-5eaf-49f6-b966-fc33c10e0748) to debug, then I noticed the computed pool address from the view-only quoter is non-existent on Base. I was using the wrong v3 core factory when deploying to Base. I already fixed that and re-deployed Uniswap/view-quoter-v3#12, but we also need to update the quoter deploy address in SOR, so that routing-api quote accuracy can go up on Base. - **What is the new behavior (if this is a feature change)?** Update [quoter](https://basescan.org/address/0x222cA98F00eD15B1faE10B61c277703a194cf5d2#code) address - **Other information**:
BitAI-dev
pushed a commit
to BitAI-dev/smart-order-router
that referenced
this pull request
Jan 20, 2025
- **What kind of change does this PR introduce?** (Bug fix, feature, docs update, ...) Big fix - **What is the current behavior?** (You can also link to an open issue here) Since shadow quoting in Base today (Uniswap/routing-api#598), the accuracy has been low:  I used tenderly [simulation](https://www.tdly.co/shared/simulation/cf37f5ed-5eaf-49f6-b966-fc33c10e0748) to debug, then I noticed the computed pool address from the view-only quoter is non-existent on Base. I was using the wrong v3 core factory when deploying to Base. I already fixed that and re-deployed Uniswap/view-quoter-v3#12, but we also need to update the quoter deploy address in SOR, so that routing-api quote accuracy can go up on Base. - **What is the new behavior (if this is a feature change)?** Update [quoter](https://basescan.org/address/0x222cA98F00eD15B1faE10B61c277703a194cf5d2#code) address - **Other information**:
BitAI-dev
pushed a commit
to Taiki-ops/smart-order-router
that referenced
this pull request
Jan 20, 2025
- **What kind of change does this PR introduce?** (Bug fix, feature, docs update, ...) Big fix - **What is the current behavior?** (You can also link to an open issue here) Since shadow quoting in Base today (Uniswap/routing-api#598), the accuracy has been low:  I used tenderly [simulation](https://www.tdly.co/shared/simulation/cf37f5ed-5eaf-49f6-b966-fc33c10e0748) to debug, then I noticed the computed pool address from the view-only quoter is non-existent on Base. I was using the wrong v3 core factory when deploying to Base. I already fixed that and re-deployed Uniswap/view-quoter-v3#12, but we also need to update the quoter deploy address in SOR, so that routing-api quote accuracy can go up on Base. - **What is the new behavior (if this is a feature change)?** Update [quoter](https://basescan.org/address/0x222cA98F00eD15B1faE10B61c277703a194cf5d2#code) address - **Other information**:
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I realized not every chain has the same v3 core factory address. From https://github.com/Uniswap/sdk-core/blob/main/src/addresses.ts, I see some chains have different addresses. I accidentally deployed quoter on Base with the default v3 core factory address, which is non-existent on Base.
I tried new deploy, and the new quoter can read the v3 factory