Rd & logs refactoring #1399
Merged
Rd & logs refactoring #1399
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
korifey
approved these changes
Nov 22, 2022
denis-fokin
reviewed
Nov 22, 2022
denis-fokin
reviewed
Nov 22, 2022
utbot-framework-api/src/main/kotlin/org/utbot/framework/UtSettings.kt
Outdated
Show resolved
Hide resolved
denis-fokin
reviewed
Nov 22, 2022
utbot-framework-api/src/main/kotlin/org/utbot/framework/UtSettings.kt
Outdated
Show resolved
Hide resolved
denis-fokin
reviewed
Nov 22, 2022
utbot-framework-api/src/main/kotlin/org/utbot/framework/UtSettings.kt
Outdated
Show resolved
Hide resolved
denis-fokin
reviewed
Nov 22, 2022
utbot-framework-api/src/main/kotlin/org/utbot/framework/UtSettings.kt
Outdated
Show resolved
Hide resolved
denis-fokin
reviewed
Nov 22, 2022
utbot-framework-api/src/main/kotlin/org/utbot/framework/UtSettings.kt
Outdated
Show resolved
Hide resolved
sergeypospelov
approved these changes
Nov 23, 2022
utbot-instrumentation/src/main/kotlin/org/utbot/instrumentation/rd/InstrumentedProcess.kt
Outdated
Show resolved
Hide resolved
utbot-instrumentation/src/main/kotlin/org/utbot/instrumentation/ConcreteExecutor.kt
Show resolved
Hide resolved
utbot-intellij/src/main/kotlin/org/utbot/intellij/plugin/generator/CodeGenerationController.kt
Show resolved
Hide resolved
|
@denis-fokin @sergeypospelov @olganaumenko please, read design docs |
Domonion
force-pushed
the
kononov-rd-refactoring-1
branch
from
b79d242 to
f02b9f2
Compare
Domonion
force-pushed
the
kononov-rd-refactoring-1
branch
from
f02b9f2 to
14ad3db
Compare
denis-fokin
approved these changes
Nov 25, 2022
utbot-framework/src/main/kotlin/org/utbot/framework/codegen/domain/Domain.kt
Outdated
Show resolved
Hide resolved
utbot-framework/src/main/kotlin/org/utbot/framework/concrete/UtExecutionInstrumentation.kt
Show resolved
Hide resolved
...strumentation/src/main/kotlin/org/utbot/instrumentation/process/InstrumentedProcessRunner.kt
Outdated
Show resolved
Hide resolved
.../src/main/kotlin/org/utbot/instrumentation/rd/generated/InstrumentedProcessRoot.Generated.kt
Show resolved
Hide resolved
utbot-rd/src/main/kotlin/org/utbot/rd/exceptions/InstantProcessDeathException.kt
Show resolved
Hide resolved
utbot-rd/src/main/kotlin/org/utbot/rd/exceptions/InstantProcessDeathException.kt
Show resolved
Hide resolved
Domonion
force-pushed
the
kononov-rd-refactoring-1
branch
2 times, most recently
from
da2882e to
d211adf
Compare
Multiple refactorings and enhacements for process starting. Removed UtSettings.logConcreteExecutionErrors and UtSettings.engineProcessLogLevel switches. Logs for engine and concrete executor processes are always enabled. Switched log configuration to utbot-intellij/log4j2.xml. Use UtSettings#getIdeaProcessLogConfigFile from ~/.utbot/settings.properties to configure logs for engine and concrete executor processes without rebuilding plugin.
Enabling suspend and port choosing by utsettings Run configurations for debugging Instant process death detection Orphan processes termination system Some text loading optimization ChildProcess -> InstrumentedProcess Rd-based UtSettings for InstrumentedProcess
Rd version bump, model regeneration typos and small adjustments
Rewriting design docs for inter process debugging and rd. Completely new design doc go inter process logging
review fix
review fix
Domonion
force-pushed
the
kononov-rd-refactoring-1
branch
from
d211adf to
c7b4b9b
Compare
debug run configurations fix
sergeypospelov
approved these changes
Nov 26, 2022
| UtBot consists of 3 different processes: | ||
| 1. `IDEA process` - the one where plugin part executes. Also can be called `plugin process`, `IDE process`. | ||
| 2. `Engine process` - process where unit test generation engine executes. | ||
| 3. `InstrumentedProces` - process where concrete execution takes place. |
There was a problem hiding this comment.
Suggested change
| 3. `InstrumentedProces` - process where concrete execution takes place. | |
| 3. `InstrumentedProcess` - process where concrete execution takes place. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Multiple refactorings and enhacements for process starting.
Removed
UtSettings.logConcreteExecutionErrorsandUtSettings.engineProcessLogLevelswitches.Logs for engine and concrete executor processes are always enabled.
Switched log configuration to
utbot-intellij/log4j2.xml.Use
UtSettings#getIdeaProcessLogConfigFilefrom~/.utbot/settings.propertiesto configure logs for engine and concrete executor processes without rebuilding plugin.Enabling suspend and port choosing by utsettings.
Run configurations for debugging.
Instant process death detection.
Orphan processes termination system.
Some text loading optimization.
ChildProcess -> InstrumentedProcess.
Rd-based UtSettings for InstrumentedProcess.
partially solves #1365
fix #1427
Type of Change
How Has This Been Tested?
CI